Re: I18N: automatic determination of potfiles list

[DJ Delorie <dj at redhat dot com>]

> Bootstrapped i686-linux; ok to apply?

I will comment only on the Makefile/configure parts...

Starting with, should this be something enabled by
--enable-maintainer-mode ?  It isn't obvious how it's disabled when
the tools aren't available.

> -native: config.status auto-host.h intl.all $(LANGUAGES) \
> +native: config.status auto-host.h intl.all @POSUB@ $(LANGUAGES) \
>  	$(EXTRA_PASSES) $(EXTRA_PROGRAMS) $(USE_COLLECT2)

"po" is a directory.  You want to avoid listing
a directory as a dependency unless you really mean it...

> +CATALOGS = @CATALOGS@
> +
> +po: $(CATALOGS)

Which it looks like you aren't, or that rule is wrong.  Unless you
really mean to make the po directory depend on the files within it,
which IMHO is a bad idea.  Perhaps a stamp-po should be used?

> +# Dummy rule to deal with dependency produced by use of
> +# "install-@POSUB@" above, when NLS is disabled.
> +install-:

This should probably have an '@true' command.  Maybe a .PHONY too.

> +install-po:
> +	$(mkinstalldirs) $(DESTDIR)$(datadir)
> +	for cat in $(CATALOGS); do \
> +	  cat=`basename $$cat`; \
> +	  lang=`echo $$cat | sed 's/\.gmo$$//'`; \
> +	  dir=$(localedir)/$$lang/LC_MESSAGES; \
> +	  $(mkinstalldirs) $(DESTDIR)$$dir; \

Check for this mkinstalldirs failing?

> +# Create po/ as an empty directory; used by the .po/.gmo build rules for
> +# scratch space.
> +test -d po || mkdir po

Shouldn't the Makefile do this?