This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Some more fortran safe-ctype & cleanups


 > From: Toon Moene <toon@moene.indiv.nluug.nl>
 > 
 > Zack Weinberg wrote:
 > 
 > > '\0' is in is_nvspace because we decided it made the most sense to
 > > treat it as whitespace.  It's a bit risky to add that to the set used
 > > by Fortran without making sure that this won't break anything else.
 > 
 > Kaveh, I'd like to second this.  Fortran is rather peculiar in its
 > interpretation of source text (think: 80-column punch card).  Craig
 > probably arrived at the code as it is after much experimentation (and
 > complaints ;-)  Please only change it to something that has *exactly*
 > the same semantics ....

Um, that's what I thought my original patch did.  Neil was the one
advocating is_nvspace, not me. :-)

My patch does this:

is_space -> ISSPACE
is_hor_space -> ISSPACE && != '\n'

and my reading of safe-ctype vs `ffecom_initialize_char_syntax_' leads
me to believe this preserves the exact same sematics.

		--Kaveh
--
Kaveh R. Ghazi			Engagement Manager / Project Services
ghazi@caip.rutgers.edu		Qwest Internet Solutions


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]