This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH]: Remove some regset abuses
- To: Daniel Berlin <dan at cgsoftware dot com>
- Subject: Re: [PATCH]: Remove some regset abuses
- From: law at redhat dot com
- Date: Wed, 24 Oct 2001 13:45:30 -0600
- cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>
- Reply-To: law at redhat dot com
In message <87y9m739fe.fsf@cgsoftware.com>you write:
> These uses (and some others i'll catch soon) mainly do set and clear
> on sparse bitmaps.
> I.E. They are using them as if they were constant time set and clear.
>
> The new bitmap implementation has a slightly higher constant for set
> and clear, and this has a *large* effect on speed of bitmap uses like the
> below, since that's all they do. Test is now constant time, but since
> these places never do tests, it doesn't help.
>
> 2001-10-19 Daniel Berlin <dan@cgsoftware.com>
>
> * sched-deps.c: Make reg_pending_sets and reg_pending_clobbers sbitmaps
> .
>
> * local-alloc.c (update_equiv_regs): Make cleared_regs an sbitmap,
> rather than a regset.
>
> * cse.c: Add approx_reg_cost_set sbitmap.
> (approx_reg_cost_1): Use sbitmap, rather than regset.
> (approx_reg_cost): Ditto.
> (cse_main): Allocate and free approx_reg_cost_set sbitmap.
OK. However, I would ask that you move the definition of approx_reg_cost_set
up to the to of the file with all the other static variables.
Presumably you've bootstrapped and tested this change?
jeff