Re: [requires global-write-privileged reviewer] Re: [PATCH] configury cleanup

[Franz Sirl <Franz dot Sirl-kernel at lauterbach dot com>]

On Friday 19 October 2001 01:22, Geoff Keating wrote:
> Alexandre Oliva <aoliva@redhat.com> writes:
> > On Sep 30, 2001, Franz Sirl <Franz.Sirl-kernel@lauterbach.com> wrote:
> > > OK to commit to mainline?
> >
> > [ http://gcc.gnu.org/ml/gcc-patches/2001-09/msg01290.html ]
> >
> > Sorry that it took so long for me to review this one.
>
> ...
>
> > What I can do for now is approve the changes that affect mn10300-elf,
> > sh-hms, sh-elf and sh-linux, and defer the rest to the maintainer of
> > each port or to someone with global write privileges.  I can vow that
> > the patch looks quite reasonable, and recommend it to be approved,
> > which I do, but I can't approve it myself.
>
> The patch is OK, although it'd be better if it deleted a blank line here:
>
> +++ gcc/config/mn10200/mn10200.h        2001/09/30 17:08:08
> @@ -21,7 +21,6 @@ along with GNU CC; see the file COPYING.
>  the Free Software Foundation, 59 Temple Place - Suite 330,
>  Boston, MA 02111-1307, USA.  */
>
> -#include "svr4.h"
>
>  /* Get rid of svr4.h stuff we don't want/need.  */
>  #undef ASM_SPEC
>
> and in various other places.


Thanks for the approval, I committed the patch with the appended obvious & 
tested hunks added, so these platforms don't break.

On the doubled blank lines, I'll happily change that, but I somehow got the 
impression that 2 blank lines are the standard thing after the copyright 
statement. Am I wrong?

Franz.


Index: gcc/config.gcc
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config.gcc,v
retrieving revision 1.97
diff -u -p -r1.97 config.gcc
--- gcc/config.gcc      2001/10/17 20:39:07     1.97
+++ gcc/config.gcc      2001/10/19 21:32:40
@@ -662,17 +669,17 @@ clipper-intergraph-clix*)
        install_headers_dir=install-headers-cpio
        ;;
 cris-*-aout)
-       tm_file="dbxelf.h cris/cris.h cris/aout.h"
+       tm_file="dbxelf.h ${tm_file} cris/aout.h"
        gas=yes
        tmake_file="cris/t-cris cris/t-aout"
        ;;
 cris-*-elf | cris-*-none)
-       tm_file="elfos.h cris/cris.h"
+       tm_file="elfos.h ${tm_file}"
        tmake_file="cris/t-cris cris/t-elfmulti"
        gas=yes
        ;;
 cris-*-linux*)
-       tm_file="linux.h cris/cris.h cris/linux.h"
+       tm_file="elfos.h svr4.h linux.h ${tm_file} cris/linux.h"
        tmake_file="cris/t-cris t-slibgcc-elf-ver cris/t-linux"
        extra_parts="crtbegin.o crtbeginS.o crtend.o crtendS.o"
        case x${enable_threads} in
@@ -1173,8 +1181,8 @@ i[34567]86-*-linux*)      # Intel 80386's run
        ;;
 x86_64-*-linux*)
        xmake_file=x-linux
-       tm_file="i386/biarch64.h i386/i386.h i386/att.h linux.h i386/x86-64.h \
-                i386/linux64.h"
+       tm_file="i386/biarch64.h i386/i386.h i386/att.h elfos.h svr4.h linux.h \
+                i386/x86-64.h i386/linux64.h"
        tmake_file="t-slibgcc-elf-ver t-linux i386/t-crtstuff"
        extra_parts="crtbegin.o crtbeginS.o crtend.o crtendS.o"
        gnu_ld=yes