This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [requires global-write-privileged reviewer] Re: [PATCH] configury cleanup
- To: Alexandre Oliva <aoliva at redhat dot com>
- Subject: Re: [requires global-write-privileged reviewer] Re: [PATCH] configury cleanup
- From: Geoff Keating <geoffk at geoffk dot org>
- Date: 18 Oct 2001 16:22:34 -0700
- CC: Franz dot Sirl-kernel at lauterbach dot com, gcc-patches at gcc dot gnu dot org
- References: <200109301903.f8UJ3tO22186@cupuacu.lsd.ic.unicamp.br> <or7ktsoj5y.fsf@free.redhat.lsd.ic.unicamp.br>
Alexandre Oliva <aoliva@redhat.com> writes:
> On Sep 30, 2001, Franz Sirl <Franz.Sirl-kernel@lauterbach.com> wrote:
>
> > OK to commit to mainline?
> [ http://gcc.gnu.org/ml/gcc-patches/2001-09/msg01290.html ]
>
> Sorry that it took so long for me to review this one.
>
...
> What I can do for now is approve the changes that affect mn10300-elf,
> sh-hms, sh-elf and sh-linux, and defer the rest to the maintainer of
> each port or to someone with global write privileges. I can vow that
> the patch looks quite reasonable, and recommend it to be approved,
> which I do, but I can't approve it myself.
The patch is OK, although it'd be better if it deleted a blank line here:
+++ gcc/config/mn10200/mn10200.h 2001/09/30 17:08:08
@@ -21,7 +21,6 @@ along with GNU CC; see the file COPYING.
the Free Software Foundation, 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA. */
-#include "svr4.h"
/* Get rid of svr4.h stuff we don't want/need. */
#undef ASM_SPEC
and in various other places.
> Thanks for taking the trouble to clean this mess up!
I also thank you!
--
- Geoffrey Keating <geoffk@geoffk.org>