This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch for relocatable GCC package on mingw32


 --- Christopher Faylor <cgf@redhat.com> wrote: > On Wed, Oct 10, 2001 at
06:34:52PM +1000, Danny Smith wrote:
> >Hello
> >
> >GCC for mingw needs to build a relocatable package (ie search paths
> >relative to gcc driver).  Currently the information needed to do that
> >is overriden by undefines in i386/cygwin.h,which is included by
> >i386/mingw32.h. Appended patch protects aginst these undefines.
> >
> >It also changes a few additional macros to be consistent with current
> >mingw usage and reformats a comment that keeps wrapping lines.
> >
> >Please apply to branch and trunk.
> 
> Hmm.  I'm sorry, Danny, but now that I've had a second chance to see this
> patch, I have a minor nit that didn't occur to me at first.
> 
> I'm sorry to say that I don't like the name
> WIN32_BUILD_RELOCATABLE_PACKAGE as a name.  The word "RELOCATABLE" is
> ambiguous in this case since it usually refers to object code not
> file location.
> 
> Can I suggest something like WIN32_NO_ABSOLUTE_INST_DIRS maybe?
> 
> If you agree to this name, I'll apply the patch with this change.
> 

Name change yours no problem is.
Will you also please change the changelog to thank yourself for suggesting
name :)


Danny


http://travel.yahoo.com.au - Yahoo! Travel
- Got Itchy feet? Get inspired!


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]