Re: cpplib [branch]: Unbreak -C

[Zack Weinberg <zack at codesourcery dot com>]

On Mon, Oct 08, 2001 at 12:15:36PM -0700, Mark Mitchell wrote:
> 
> 
> --On Monday, October 08, 2001 07:32:33 PM +0100 Neil Booth 
> <neil@daikokuya.demon.co.uk> wrote:
> 
> >Mark,
> >
> >Subject to the usual bootstrap / regression test, I'd like to commit
> >this to the branch.  It both fixes a 2.95.x regression (-C is quite
> >broken), and is IMO obviously safe.
> 
> I don't know this code well enough to judge the obviousness.  I trust
> you, but I'm paranoid, so I'll ask for a second opinion.
> 
> Zack, what do you think?  Is this a reasonable change?
> 
> If Zack concurs, please check it in, and let me know that you have done
> so.

It is not immediately obvious to me that this patch solves the
problem, but I trust Neil's assessment that it does.

What _is_ clear is that the worst possible undesired consequence of
this patch is that -C will not preserve all the comments that it ought
to.  Therefore, I think it is safe for the branch.

zw