This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: non-GNU make broken again during `make bootstrap'
- To: gcc-patches at gcc dot gnu dot org
- Subject: Re: PATCH: non-GNU make broken again during `make bootstrap'
- From: Loren James Rittle <rittle at latour dot rsch dot comm dot mot dot com>
- Date: Wed, 3 Oct 2001 21:25:22 -0500 (CDT)
- CC: mark at codesourcery dot com
- References: <200109280425.f8S4PHd29846@latour.rsch.comm.mot.com>
- Reply-to: rittle at labs dot mot dot com
Regarding the breakage found with the patch of this thread, Alexandre
Oliva <aoliva@redhat.com> wrote on gcc-bugs:
> I'd pass HOST_CFLAGS, HOST_LDFLAGS and HOST_CPPFLAGS, for a start. I
> don't think we need HOST_LIBS, since fixinc has never needed any
> library other than libiberty.
The issue is not what fixinc needs in any particular stage but rather
passing all the values that must be consistent across any recursive
make calls.
> Consider a patch that passes these variables down to fixinc (without
> the HOST_ prefix, of course :-) pre-approved for mainline, and
> strongly recommended for the 3.0 branch, subject to Mark's approval.
This patch moves us forward (tested by me and Robert L.):
2001-10-03 Loren J. Rittle <ljrittle@acm.org>
* Makefile.in (STAGE2_FLAGS_TO_PASS): Propagate HOST_CFLAGS,
HOST_LDFLAGS and HOST_CPPFLAGS.
Index: Makefile.in
===================================================================
RCS file: /cvs/gcc/egcs/gcc/Makefile.in,v
retrieving revision 1.742
diff -c -r1.742 Makefile.in
*** Makefile.in 2001/10/02 07:12:19 1.742
--- Makefile.in 2001/10/04 01:40:03
***************
*** 2959,2964 ****
--- 2959,2967 ----
# the context of the stage_x rule.
STAGE2_FLAGS_TO_PASS = \
HOST_CC="$(HOST_CC)" \
+ HOST_CFLAGS="$(HOST_CFLAGS)" \
+ HOST_LDFLAGS="$(HOST_LDFLAGS)" \
+ HOST_CPPFLAGS="$(HOST_CPPFLAGS)" \
CFLAGS="$(BOOT_CFLAGS)" \
LDFLAGS="$(BOOT_LDFLAGS)" \
WARN_CFLAGS="\$$(GCC_WARN_CFLAGS)" \
Installed on mainline. Awaiting approval for 3.0 branch as per
Alexandre's statement. I am just as willing to roll back the
STAGE2_FLAGS_TO_PASS part of the changes in Makefile.in on branch if
that is considered less risky (however, that means gcc 3.0.2 will not
build with BSD make unless someone else figures out an alternate safe
patch before release).
Regards,
Loren