This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch to add ACONCAT macro to libiberty
- To: dj at redhat dot com
- Subject: Re: Patch to add ACONCAT macro to libiberty
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Date: Mon, 17 Sep 2001 17:12:23 -0400 (EDT)
- Cc: gcc-patches at gcc dot gnu dot org
> From: DJ Delorie <dj@redhat.com>
>
> > > Also, I'd prefer more ansi-friendly names for the hidden functions,
> > > like __libiberty_concat_vlength instead of vconcatlen.
> >
> > Err, vconcatlen/vconcatcpy are declared static in concat.c, so I don't
> > think we need to obfuscate their names to "hide" them from modules
> > linked with libiberty:concat.o.
>
> Well, the ones that are used by the ACONCAT macro, then.
If you mean:
+ extern unsigned long concatlen PARAMS ((const char *, ...));
+ extern char *concatcpy PARAMS ((char *, const char *, ...));
+ extern char *concatcpy2 PARAMS ((const char *, ...));
I thought these might be useful in a general sense, so I made their
names friendly and documented them in libiberty.h.
This one:
+ extern char *libiberty_concat_ptr;
is an implementation detail and I did make the name obscure.
Do you really feel I need to make concat{len,cpy,cpy2} obscure?
--Kaveh
--
Kaveh R. Ghazi Engagement Manager / Project Services
ghazi@caip.rutgers.edu Qwest Internet Solutions