This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: RFC: "Generic" gthread model

On Wed, Aug 22, 2001 at 08:13:58PM +0100, Jason Merrill wrote:
> Do they look something like this?

Something like that.

> ! struct weak_syms * weak_decls;

static?

> !   else if (! (SUPPORTS_WEAK))
> !     warning_with_decl (decl, "weak declaration of `%s' not supported");
> ! 
> !   DECL_WEAK (decl) = 1;
> !   add_weak (IDENTIFIER_POINTER (DECL_ASSEMBLER_NAME (decl)), NULL);

Perhaps 

   else if (SUPPORTS_WEAK)
     add_weak (IDENTIFIER_POINTER (DECL_ASSEMBLER_NAME (decl)), NULL);
   else
     warning_with_decl (decl, "weak declaration of `%s' not supported");
   DECL_WEAK (decl) = 1;

I'd missed the warning, myself.

> ! 	  if (t->name && strcmp (name, t->name) == 0)
> ! 	    t->name = NULL;

I also fixed this to splice out the list entry that we're
killing, instead of squashing t->name.



r~
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]