This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: What is Happening with g++.dg/opt/alias1.C?


>>>>> "Jeffrey" == Jeffrey Oldham <oldham@codesourcery.com> writes:

> On Wed, Aug 08, 2001 at 10:56:45AM +0100, Jason Merrill wrote:
>> >>>>> "Jeffrey" == Jeffrey Oldham <oldham@codesourcery.com> writes:
>> 
>> > For gcc 3.1, gcc/testsuite/g++.dg/opt/alias1.C was created today, but
>> > I could not find any message sent to gcc-patches@gcc.gnu.org and no
>> > entry in gcc/testsuite/ChangeLog.  Did I miss them?
>> 
>> You missed the message to gcc-patches, entitled "PATCH to get_alias_set".

> Does not CVS's diff prepend a header before each file?

Yes.  But I didn't include the testcase in the diff, I added it as a
second attachment.  I'm certainly not the only person who does this.

Actually, I usually don't use CVS diff to make patches these days; I just
do a normal diff against the version from my last CVS update.

>> I never add entries to the testsuite ChangeLog for new tests; it seems
>> pointless.  I asked Mark for his thoughts on the subject, and he concurs.

> In my opinion, ChangeLog entries should list every code change and
> this includes new test files.  This makes them very useful to see all
> recent code changes in a directory.

I suppose I don't see why new testcases would be interesting when looking
for code changes.

>> The 1.1 entry indicates the patch which fixes the testcase.  The 1.2 entry
>> is me fixing a syntax error in the dg-options line.

> Perhaps future cvs log entries could list your more informative
> explanations.  It might help avoid receiving email from confused
> people like me. :)

I'll try to be more verbose than "oops" in future.  :)

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]