This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Merge libiberty/regex.c from glibc


DJ Delorie <dj@redhat.com> writes:

>> During compilation of GCC I noticed a few warnings in GCC that I
>> fixed in glibc, the master repository.  Since the patch has just
>> been committed to glibc, I now merge it to - together with the other
>> patches from glibc - back to GCC.
>>
>> I've committed this as it's a merge from GLIBC,
> 
> Thanks.  While there is no documented procedure for this (yet?), I
> consider the same rules apply to regex as for gcc->binutils merges:
> 
> 	Changes need to be done in tandem with the official [GCC]
> 	sources or submitted to the master file maintainer and brought
> 	in via a merge.  Note: approved patches in [gcc's libiberty]
> 	are automatically approved in [this libiberty] also; feel free
> 	to merge them yourself if needed sooner than the next merge.
> 	Otherwise, changes are automatically merged, usually within
> 	a day.

I considered this also and followed the following rule (from
cvswrite.html) since regex.c is part of glibc:

  Maintainers are free to import files maintained outside the tree
  from their official versions without explicit write approval.  Such
  files would include config.guess and config.sub.

Do you suggest that next time a change is made to regex.c that I
should commit it to gcc's libiberty?

Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]