This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Fix profile.c CFG updating


> On Fri, Jul 27, 2001 at 03:57:24PM +0200, Jan Hubicka wrote:
> > ! 	      for (e = bb->succ; e->flags & (EDGE_FAKE | EDGE_FALLTHRU); e = e->succ_next);
> 
> Please use "continue;" on the next line to document that this is
> supposed to be an empty loop body.  Line wrap.
This sounds like nice idea I was never using.
Does the coding standards mention it?  If not it may be good thing
to add.
> 
> > !     error ("Arc profiling: some edge counts were bad.");
> 
> Downcase error strings.  What's the point of this one anyway?
> It's telling us that we got error messages.  Well, we knew that
> since we saw them.
OK, I will remove this one.
> 
> > ! 	    error (".da file contents exhausted too early\n");
> 
> No newline in error strings.
> 
> You've forgotten to mention that you tested these patches on ...
Tested together with the other patches sent same day on i686
and MIPS.

OK (with the requiested changes)?
> 
> 
> r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]