This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: patch for Re: arm-rtems vs. arm-elf


>-#define CPP_PREDEFINES "-Darm -Darm_elf -Drtems -D__rtems__ -D__ELF__ \
>+#define CPP_PREDEFINES "-Darm_elf -Drtems -D__rtems__ -D__ELF__ \

You almost certainly don't want "arm_elf" either.

>I recall being told that -Drtems and -D__rtems__ are redundant. 
>Should one of them be removed.  

Yes.  If you have "-Drtems" then I think you get __rtems__ automatically.  But 
-Drtems is generally undesirable anyway because it pollutes the user's 
namespace.  So I suggest you remove that one and stick with just -D__rtems__.

>/* Get machine-independent configuration parameters for RTEMS.  */
>#include <rtems.h>
>
>Isn't the proper thing to do now is specify multiple tm_files
>in configure.in?  

Yup.  But that's just a stylistic issue.  I certainly wouldn't worry about it 
on the branch, though you might want to change to the new style on the trunk.

p.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]