This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: PATCH: Add config/cpu/mips/bits/atomicity.h for libstdc++-v3


On Thu, Jul 26, 2001 at 03:36:51PM -0400, Hans-Peter Nilsson wrote:
> On Wed, 25 Jul 2001, H . J . Lu wrote:
> > 2001-07-25  H.J. Lu <hjl@gnu.org>
> >
> > 	* configure.target (cpu_include_dir): Set to `config/cpu/mips'
> > 	for mips.
> >
> > 	* config/cpu/mips/bits/atomicity.h: New.
> 
> It looks like the new atomicity.h broke mips simulator builds
> for mips-elf/mips-sim.  This was one of the few simulator
> targets that worked when I tried it; just this and mn10300 and
> ppc).  Follow directions on
> <URL:http://gcc.gnu.org/simtest-howto.html> to repeat.  You'll
> see something like this (mind the wrapped lines):
> 
> There's no sgidefs.h in newlib, and probably not for a number of
> other mips targets.  Please fix, perhaps by making
> libstdc++-v3/config/cpu/mips/bits/atomicity.h system-specific
> rather than CPU-specific or guarding the sgidefs.h include; I
> don't know.

How about this patch? Only Linux and Irix defines _MIPS_ISA :-(.
I guess my patch is only useful for Linux/mips.

> 
> I believe this breaks C++ on most mips target systems.  I don't
> know if 3.0 is supposed to work for embedded mips targets and
> non-SGI, non-Linux, but it seems serious.  Perhaps we should

FWIW, gcc 3.0 doesn't work right on Linux/mips either.

> revert the patch. 1/2 ;-)
> 


H.J.
----
2001-07-26  H.J. Lu <hjl@gnu.org>

	* configure.target (ATOMICITYH): Set to `config/cpu/mips'
	only for Linux/mips.

--- libstdc++-v3/configure.target.mips	Thu Jul 26 10:14:22 2001
+++ libstdc++-v3/configure.target	Thu Jul 26 13:40:04 2001
@@ -39,9 +39,6 @@ case "${target_cpu}" in
   i486 | i586 | i686 | i786)
     cpu_include_dir="config/cpu/i486"
     ;;
-  mips*)
-    cpu_include_dir="config/cpu/mips"
-    ;;
   powerpc | rs6000)
     cpu_include_dir="config/cpu/powerpc"
     ;;
@@ -108,6 +105,9 @@ esac
 # THIS TABLE IS SORTED.  KEEP IT THAT WAY.
 
 case "${target}" in
+  mips*-*-linux*)
+    ATOMICITYH="config/cpu/mips"
+    ;;
    *-*-aix[456789]*)
      # We set os_include_dir to config/os/aix only on AIX 4.3 and
      # newer, but config/os/aix/bits/atomicity.h works on earlier


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]