Re: PATCH: Add config/cpu/mips/bits/atomicity.h for libstdc++-v3

[Hans-Peter Nilsson <hp at bitrange dot com>]

On Wed, 25 Jul 2001, H . J . Lu wrote:
> 2001-07-25  H.J. Lu <hjl@gnu.org>
>
> 	* configure.target (cpu_include_dir): Set to `config/cpu/mips'
> 	for mips.
>
> 	* config/cpu/mips/bits/atomicity.h: New.

It looks like the new atomicity.h broke mips simulator builds
for mips-elf/mips-sim.  This was one of the few simulator
targets that worked when I tried it; just this and mn10300 and
ppc).  Follow directions on
<URL:http://gcc.gnu.org/simtest-howto.html> to repeat.  You'll
see something like this (mind the wrapped lines):

/home/hp/builds2/mips-sim/gcc/xgcc
-B/home/hp/builds2/mips-sim/gcc/ -nostdinc++
-L/home/hp/builds2/mips-sim/mips-elf/libstdc++-v3/src
-L/home/hp/builds2/mips-sim/mips-elf/libstdc++-v3/src/.libs
-nostdinc -B/home/hp/builds2/mips-sim/mips-elf/newlib/ -isystem
/home/hp/builds2/mips-sim/mips-elf/newlib/targ-include -isystem
/home/hp/cvs_areas/combined/cvs_write/newlib/libc/include
-B/home/hp/builds2/mips-sim/../install-mipssim/mips-elf/bin/
-B/home/hp/builds2/mips-sim/../install-mipssim/mips-elf/lib/
-isystem
/home/hp/builds2/mips-sim/../install-mipssim/mips-elf/include
-L/home/hp/builds2/mips-sim/ld -nostdinc++
-I/home/hp/builds2/mips-sim/mips-elf/libstdc++-v3/include/mips-elf
-I/home/hp/builds2/mips-sim/mips-elf/libstdc++-v3/include
-I/home/hp/cvs_areas/combined/cvs_write/libstdc++-v3/libsupc++
-I/home/hp/cvs_areas/combined/cvs_write/libstdc++-v3/libmath -g
-O2 -fno-implicit-templates -Wall -Wno-format -W -Wwrite-strings
-Winline -fdiagnostics-show-location=once -g -c basic_file.cc -o
basic_file.o
In file included from
/home/hp/builds2/mips-sim/mips-elf/libstdc++-v3/include/bits/basic_string.h:39,
                 from
/home/hp/builds2/mips-sim/mips-elf/libstdc++-v3/include/bits/std_string.h:46,
                 from
/home/hp/builds2/mips-sim/mips-elf/libstdc++-v3/include/bits/localefwd.h:42,
                 from
/home/hp/builds2/mips-sim/mips-elf/libstdc++-v3/include/bits/std_ios.h:43,
                 from
/home/hp/builds2/mips-sim/mips-elf/libstdc++-v3/include/bits/basic_file.h:40,
                 from basic_file.cc:34:
/home/hp/builds2/mips-sim/mips-elf/libstdc++-v3/include/mips-elf/bits/atomicity.h:33:21:
sgidefs.h: No such file or directory
make[3]: *** [basic_file.lo] Error 1
make[3]: Leaving directory
`/mnt/miscb3/builds2/mips-sim/mips-elf/libstdc++-v3/src'

There's no sgidefs.h in newlib, and probably not for a number of
other mips targets.  Please fix, perhaps by making
libstdc++-v3/config/cpu/mips/bits/atomicity.h system-specific
rather than CPU-specific or guarding the sgidefs.h include; I
don't know.

I believe this breaks C++ on most mips target systems.  I don't
know if 3.0 is supposed to work for embedded mips targets and
non-SGI, non-Linux, but it seems serious.  Perhaps we should
revert the patch. 1/2 ;-)

brgds, H-P