This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] flow.c: Don't call sets_cc0_p if insn is NULL_RTX.
- To: Richard Henderson <rth at redhat dot com>
- Subject: Re: [patch] flow.c: Don't call sets_cc0_p if insn is NULL_RTX.
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- Date: Wed, 25 Jul 2001 13:56:10 -0400 (EDT)
- cc: Kazu Hirata <kazu at hxi dot com>, <gcc-patches at gcc dot gnu dot org>
On Wed, 25 Jul 2001, Richard Henderson wrote:
> On Wed, Jul 25, 2001 at 11:57:18AM -0400, Hans-Peter Nilsson wrote:
> > > + #ifdef HAVE_cc0
> > > + if (reg_mentioned_p (cc0_rtx, PATTERN (insn)))
> > > + kill_from = PREV_INSN (insn);
> >
> > I believe that PREV_INSN should be prev_nonnote_insn as in the
> > code you deleted below. The notes can get there from inlining.
>
> No, there should never ever be *anything* between cc0 settter and user.
Yes there will. There will be notes at times, specifically from
inlining. At least there was last time we had such a bug.
Please have a look at
<URL:http://gcc.gnu.org/ml/gcc-patches/2000-06/msg00369.html>.
brgds, H-P