This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix store motion, revised PRE memory handling
- To: Daniel Berlin <dan at cgsoftware dot com>
- Subject: Re: [PATCH] Fix store motion, revised PRE memory handling
- From: Richard Henderson <rth at redhat dot com>
- Date: Mon, 16 Jul 2001 00:02:03 -0700
- Cc: gcc-patches at gcc dot gnu dot org
- References: <87y9ppe8bl.fsf@cgsoftware.com>
On Mon, Jul 16, 2001 at 01:45:02AM -0400, Daniel Berlin wrote:
> There is a consistent pattern of
>
> if (load_killed_in_block_p (...)) <which is the way you want to handle it>
> if (mem_*set_* crap) <which is what we used to do>
Wow, that's ... stunning. I can only guess that there was
a botched cvs merge at some point in the past.
> This patch won't be committed until a proper fix is committed to df.c
> to fix the not marking all the right regs as def'd in call insns, but
> i'd still like it reviewed anyway, since that's just a simple matter
> to fix anyway.
I'm working on that.
This is a somewhat large-ish. Would you split out the stupidity
killing into a separate patch? It would make it easier to examine
the actual logic changes you've got in there.
r~