This is the mail archive of the
mailing list for the GCC project.
Re: Trivial toplev.c patch
- To: Richard Kenner <kenner at vlsi1 dot ultra dot nyu dot edu>
- Subject: Re: Trivial toplev.c patch
- From: Stan Shebs <shebs at apple dot com>
- Date: Thu, 12 Jul 2001 18:01:32 -0700
- CC: jsm28 at cam dot ac dot uk, gcc-patches at gcc dot gnu dot org
- References: <10107130052.AA25682@vlsi1.ultra.nyu.edu>
Richard Kenner wrote:
> No, the right thing is to put ASM_FILE_START in the target structure;
> anything else is just a temporary fix.
> Please explain why you propose putting things that were perfectly clear as
> macros into some other mechanism.
> I can understand using the target structure for places where things weren't
> already clean, but it seems a very heavy mechanism for something simple
> like this.
For consistency, which as you just pointed out is a desirable thing.
The mechanism isn't that heavyweight anyway - targetizing ASM_FILE_START
will result in a net reduction in the amount of GCC code, since many
of these have functions already, so you eliminate the macro and use
the function directly.