This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Avoid signed/unsigned warnigs
- To: gcc-patches at gcc dot gnu dot org
- Subject: Re: Avoid signed/unsigned warnigs
- From: Jan van Male <jan dot vanmale at fenk dot wau dot nl>
- Date: Wed, 11 Jul 2001 23:09:26 +0200
- Cc: "John David Anglin" <dave at hiauly1 dot hia dot nrc dot ca>
>> which changed `mode_size' from `int' to `unsigned'. This patch eliminates
>> the warnings by adding an explicit cast to `int' of GET_MODE_SIZE and
>> GET_MODE_BITSIZE.
>
>For INTVAL comparisons, I suggest using `HOST_WIDE_INT' rather than `int'.
>This is the type extracted by INTVAL. On some machines, it is wider than
>`int' making the cast from `unsigned int' safer.
>
I understand why this is true in general. However, as I argued, the maximum
value of the unsigned int is 4096. Furthermore, GET_MODE_SIZE is cast to
int elsewhere in combine.c. So I think the patch is good as it is.
jan
>Dave
>--
>J. David Anglin dave.anglin@nrc.ca
>National Research Council of Canada (613) 990-0752 (FAX: 952-6605)