This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Add v3 mangler tests to libiberty
- To: Michael Elizabeth Chastain <chastain at cygnus dot com>
- Subject: Re: [PATCH] Add v3 mangler tests to libiberty
- From: Daniel Berlin <dan at cgsoftware dot com>
- Date: Sun, 08 Jul 2001 15:16:51 -0400
- Cc: dan at cgsoftware dot com, gcc-patches at gcc dot gnu dot org
- References: <200107081806.LAA30339@bosch.cygnus.com>
Michael Elizabeth Chastain <firstname.lastname@example.org> writes:
> I proofread this and it looks good to me. I selected 4 names at random
> and hand-checked them using the ABI spec.
> std::logic_error::logic_error(std::string const&)
> std::string::find_first_not_of(char, unsigned) const
> std::moneypunct_byname<char, true>::~moneypunct_byname()
> I tested on two platforms: native i686-pc-linux-gnu (red hat linux 7)
> and native sparc-sun-solaris2.8. I used a CVS pull dated 2001-06-30
> from gcc-3_0-branch. On both platforms, 'make check' reports:
> All 4651 tests passed
> I have some enhancement requests:
> . add a comment referring to the "C++ ABI for Itanium" document:
> . add a comment documenting where the test cases came from
> . add a comment indicating whether we expect these test cases to
> cover the spec (my guess is that no one has checked and they
> probably don't).
I know they don't.
We already know the demangler fails at some cases, so it's not
covering the whole spec.
I'll add them.
(I know they aren't demangled properly because I have a new
cp-demangle.c that *does* demangle them properly, but it's not quite
> With a little more documentation, I recommend this pach for approval.
"I play the harmonica. The only way I can play is if I get my
car going really fast, and stick it out the window. I've been
arrested three times for practicing.