This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] Add v3 mangler tests to libiberty


Michael Elizabeth Chastain <chastain@cygnus.com> writes:

> I proofread this and it looks good to me.  I selected 4 names at random
> and hand-checked them using the ABI spec.
> 
>   _ZNSt11logic_errorC1ERKSs
>   std::logic_error::logic_error(std::string const&)
> 
>   _ZNSt10ctype_base6xdigitE
>   std::ctype_base::xdigit
> 
>   _ZNKSs17find_first_not_ofEcj
>   std::string::find_first_not_of(char, unsigned) const
> 
>   _ZNSt17moneypunct_bynameIcLb1EED2Ev
>   std::moneypunct_byname<char, true>::~moneypunct_byname()
> 
> I tested on two platforms: native i686-pc-linux-gnu (red hat linux 7)
> and native sparc-sun-solaris2.8.  I used a CVS pull dated 2001-06-30
> from gcc-3_0-branch.  On both platforms, 'make check' reports:
> 
>   All 4651 tests passed
> 
> I have some enhancement requests:
> 
> . add a comment referring to the "C++ ABI for Itanium" document:
>   http://www.codesourcery.com/cxx-abi/abi.html

Okeydokey.

> 
> . add a comment documenting where the test cases came from

Okeydokey.

> 
> . add a comment indicating whether we expect these test cases to
>   cover the spec (my guess is that no one has checked and they
>   probably don't).

I know they don't. 
We already know the demangler fails at some cases, so it's not
covering the whole spec.
I'll add them.
(I know they aren't demangled properly because I have a new
cp-demangle.c that *does* demangle them properly, but it's not quite
ready yet.)


> 
> With a little more documentation, I recommend this pach for approval.
> 
> MichaelC

-- 
"I play the harmonica.  The only way I can play is if I get my
car going really fast, and stick it out the window.  I've been
arrested three times for practicing.
"-Steven Wright


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]