Re: PATCH: Pascal Strings -- TAKE FOUR

[Fergus Henderson <fjh at cs dot mu dot oz dot au>]

On 03-Jul-2001, Ziemowit Laski <zlaski@apple.com> wrote:

> Index: gcc/c-lex.c
...
> + 	      error (wide?
> + 		       "Pascal string-length escape (\\p) not allowed in wide string":
> + 		       "Pascal string-length escape (\\p) must be at beginning of string");

The GNU Coding Standards say "When you split an expression into multiple lines,
split it before an operator, not after one." So that should be

 	      error (wide
	             ? "Pascal string-length escape (\\p) not allowed in wide string"
 		     : "Pascal string-length escape (\\p) must be at beginning of string");

BTW, if review comments are just about layout/whitespace, like this one,
is it better to send them directly to the poster rather than to the list?

> Index: gcc/c-common.c
> + static tree
> + choose_string_type (wide_flag, ps_flag)
> +      int wide_flag, ps_flag;
> + {
> +   /* Pascal strings are not supported in wide mode */
> +   return (wide_flag ? wchar_type_node : (ps_flag ? unsigned_char_type_node : char_type_node));

Is there a gcc policy on wrapping long lines?

-- 
Fergus Henderson <fjh@cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.