This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [C++ patch]: reorganize tree inlining


> 2001-07-01  Nathan Sidwell  <nathan@codesourcery.com>
...
> --- invoke.texi	2001/06/29 14:58:24
> *************** in the following sections.
> *** 239,244 ****
> --- 239,245 ----
>   -a  -ax  -d@var{letters}  -dumpspecs  -dumpmachine  -dumpversion @gol
>   -fdump-unnumbered -fdump-translation-unit@r{[}-@var{n}@r{]} -fdump-class-hierarchy@r{[}-@var{n}@r{]} @gol
>   -fdump-ast-original@r{[}-@var{n}@r{]} -fdump-ast-optimized@r{[}-@var{n}@r{]} @gol
> + -fdump-ast-inlined@r{[}-@var{n}@r{]} @gol
>   -fmem-report  -fpretend-float @gol
>   -fprofile-arcs  -ftest-coverage  -ftime-report @gol
>   -g  -g@var{level}  -gcoff  -gdwarf  -gdwarf-1  -gdwarf-1+  -gdwarf-2 @gol
> *************** The following tree dumps are possible:
> *** 3029,3034 ****
> --- 3030,3038 ----
>   Dump before any tree based optimization, to @file{@var{file}.original}.
>   @item optimized
>   Dump after all tree based optimization, to @file{@var{file}.optimized}.
> + @item inlined
> + Dump after inlining within the body of the function, to
> + @file{@var{file}.inlined}.
>   @end table

I think it would be nicer to put the documentation of `inlined'
before the documentation for `optimized', i.e. to list the different
stages in cronological order.

It would also be nice to include stage numbers in the dump file names,
e.g.
	@var{file}.01-original
	@var{file}.02-inlined
	@var{file}.03-optimized
or maybe
	@var{file}.tree.01-original
	@var{file}.tree.02-inlined
	@var{file}.tree.03-optimized
though perhaps that should be a separate change.

Also it would be nice to document what optimizations are included
in the `optimized' tree but not in the `inlined' tree.

> Index: c-dump.c
> ===================================================================
> RCS file: /cvs/gcc/egcs/gcc/c-dump.c,v
> retrieving revision 1.4
> diff -c -3 -p -r1.4 c-dump.c
> *** c-dump.c	2001/06/05 08:03:44	1.4
> --- c-dump.c	2001/07/01 19:44:57
> *************** static struct dump_file_info dump_files[
> *** 802,807 ****
> --- 802,808 ----
>     {".original", "dump-ast-original", 0, 0},
>     {".optimized", "dump-ast-optimized", 0, 0},
>     {".class", "dump-class-hierarchy", 0, 0},
> +   {".inlined", "dump-ast-inlined", 0, 0},
>   };

Here too I'd prefer chronological order, although it's much less important
here.

-- 
Fergus Henderson <fjh@cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]