Re: PATCH: Darwin pragmas

[Geoff Keating <geoffk at geoffk dot org>]

Stan Shebs <shebs@apple.com> writes:

> Here are four target-specific pragmas that Darwin systems need to
> support.  In the absence of any consensus on adding documentation or
> testsuite for pragmas, the patch doesn't include those, but of course
> I'd be happy to write them if it's agreed that they are desirable.

Yes, please, testcases for every feature.  I think we decided that
even target-specific pragmas should have documentation, but presumably
in a target-specific section of the docs...  I'm not sure where that
might go.  Probably in the bit about 'C extensions', have a sub-node
for pragmas, and a second sub-node for 'pragmas for Darwin'.

> + #define BAD(msgid) do { warning (msgid); return; } while (0)

This might cause localisation trouble.  You might need something
to tell gettext that 'BAD' in this file has a parameter of a string
that is to be translated.

-- 
- Geoffrey Keating <geoffk@geoffk.org>