This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.
Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Fix thinko in params

To: gcc-patches at gcc dot gnu dot org
Subject: Fix thinko in params
From: Daniel Berlin <dan at cgsoftware dot com>
Date: Tue, 26 Jun 2001 01:15:26 -0400
1. Things that depended on params.h didn't depend on params.def, so if
   you changed params.def, none of the really affected files got
   recompiled.
2. In toplev.c, when displaying help, it would do
for (i = sizeof(compiler_params); ....)

Since compiler_params is a pointer, this is a pretty silly thing to be
doing. :)


2001-06-26  Daniel Berlin  <dan@cgsoftware.com>

	* toplev.c (display_help): Fix param thinko.
	* Makefile.in: Fix params.h dependencies.

Index: Makefile.in
===================================================================
RCS file: /cvs/gcc/egcs/gcc/Makefile.in,v
retrieving revision 1.680
diff -c -3 -p -w -B -b -r1.680 Makefile.in
*** Makefile.in	2001/06/20 07:18:11	1.680
--- Makefile.in	2001/06/26 05:03:52
*************** TM_P_H = tm_p.h $(tm_p_file_list) insn-c
*** 557,562 ****
--- 557,563 ----
  MACHMODE_H = machmode.h machmode.def
  RTL_BASE_H = rtl.h rtl.def $(MACHMODE_H)
  RTL_H = $(RTL_BASE_H) genrtl.h
+ $(PARAMS_H) = $(PARAMS_H) params.def
  TREE_H = tree.h real.h tree.def $(MACHMODE_H) tree-check.h version.h builtins.def
  BASIC_BLOCK_H = basic-block.h bitmap.h sbitmap.h varray.h
  DEMANGLE_H = $(srcdir)/../include/demangle.h
*************** toplev.o : toplev.c $(CONFIG_H) $(SYSTEM
*** 1335,1341 ****
     insn-config.h intl.h $(RECOG_H) Makefile toplev.h dwarfout.h \
     dwarf2out.h sdbout.h dbxout.h $(EXPR_H) hard-reg-set.h $(BASIC_BLOCK_H) \
     graph.h $(LOOP_H) except.h $(REGS_H) $(TIMEVAR_H) $(lang_options_files) \
!    ssa.h params.h $(TM_P_H) reload.h dwarf2asm.h
  	$(CC) $(ALL_CFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) $(MAYBE_USE_COLLECT2) \
  	  -DTARGET_NAME=\"$(target_alias)\" \
  	  -c $(srcdir)/toplev.c
--- 1336,1342 ----
     insn-config.h intl.h $(RECOG_H) Makefile toplev.h dwarfout.h \
     dwarf2out.h sdbout.h dbxout.h $(EXPR_H) hard-reg-set.h $(BASIC_BLOCK_H) \
     graph.h $(LOOP_H) except.h $(REGS_H) $(TIMEVAR_H) $(lang_options_files) \
!    ssa.h $(PARAMS_H) $(TM_P_H) reload.h dwarf2asm.h
  	$(CC) $(ALL_CFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) $(MAYBE_USE_COLLECT2) \
  	  -DTARGET_NAME=\"$(target_alias)\" \
  	  -c $(srcdir)/toplev.c
*************** real.o : real.c $(CONFIG_H) $(SYSTEM_H) 
*** 1408,1414 ****
  integrate.o : integrate.c $(CONFIG_H) $(SYSTEM_H) $(RTL_H) $(TREE_H) flags.h \
     $(INTEGRATE_H) insn-config.h $(EXPR_H) real.h $(REGS_H) \
     intl.h function.h output.h $(RECOG_H) except.h toplev.h $(LOOP_H) \
!    params.h $(TM_P_H)
  jump.o : jump.c $(CONFIG_H) $(SYSTEM_H) $(RTL_H) flags.h hard-reg-set.h $(REGS_H) \
     insn-config.h $(RECOG_H) $(EXPR_H) real.h except.h function.h \
     toplev.h $(INSN_ATTR_H) $(TM_P_H) reload.h $(PREDICT_H)
--- 1409,1415 ----
  integrate.o : integrate.c $(CONFIG_H) $(SYSTEM_H) $(RTL_H) $(TREE_H) flags.h \
     $(INTEGRATE_H) insn-config.h $(EXPR_H) real.h $(REGS_H) \
     intl.h function.h output.h $(RECOG_H) except.h toplev.h $(LOOP_H) \
!    $(PARAMS_H) $(TM_P_H)
  jump.o : jump.c $(CONFIG_H) $(SYSTEM_H) $(RTL_H) flags.h hard-reg-set.h $(REGS_H) \
     insn-config.h $(RECOG_H) $(EXPR_H) real.h except.h function.h \
     toplev.h $(INSN_ATTR_H) $(TM_P_H) reload.h $(PREDICT_H)
*************** cse.o : cse.c $(CONFIG_H) $(SYSTEM_H) $(
*** 1424,1435 ****
     $(BASIC_BLOCK_H) $(GGC_H) $(TM_P_H)
  gcse.o : gcse.c $(CONFIG_H) $(SYSTEM_H) $(RTL_H) $(REGS_H) hard-reg-set.h \
     flags.h real.h insn-config.h ggc.h $(RECOG_H) $(EXPR_H) $(BASIC_BLOCK_H) \
!    function.h output.h toplev.h $(TM_P_H) params.h
  sibcall.o : sibcall.c $(CONFIG_H) $(SYSTEM_H) $(RTL_H) $(REGS_H) function.h \
     hard-reg-set.h flags.h insn-config.h $(RECOG_H) $(BASIC_BLOCK_H)
  resource.o : resource.c $(CONFIG_H) $(RTL_H) hard-reg-set.h $(SYSTEM_H) \
     $(BASIC_BLOCK_H) $(REGS_H) flags.h output.h resource.h function.h toplev.h \
!    $(INSN_ATTR_H) except.h params.h $(TM_P_H)
  lcm.o : lcm.c $(CONFIG_H) $(SYSTEM_H) $(RTL_H) $(REGS_H) hard-reg-set.h flags.h \
     real.h insn-config.h $(INSN_ATTR_H) $(RECOG_H) $(EXPR_H) $(BASIC_BLOCK_H) \
     $(TM_P_H)
--- 1425,1436 ----
     $(BASIC_BLOCK_H) $(GGC_H) $(TM_P_H)
  gcse.o : gcse.c $(CONFIG_H) $(SYSTEM_H) $(RTL_H) $(REGS_H) hard-reg-set.h \
     flags.h real.h insn-config.h ggc.h $(RECOG_H) $(EXPR_H) $(BASIC_BLOCK_H) \
!    function.h output.h toplev.h $(TM_P_H) $(PARAMS_H)
  sibcall.o : sibcall.c $(CONFIG_H) $(SYSTEM_H) $(RTL_H) $(REGS_H) function.h \
     hard-reg-set.h flags.h insn-config.h $(RECOG_H) $(BASIC_BLOCK_H)
  resource.o : resource.c $(CONFIG_H) $(RTL_H) hard-reg-set.h $(SYSTEM_H) \
     $(BASIC_BLOCK_H) $(REGS_H) flags.h output.h resource.h function.h toplev.h \
!    $(INSN_ATTR_H) except.h $(PARAMS_H) $(TM_P_H)
  lcm.o : lcm.c $(CONFIG_H) $(SYSTEM_H) $(RTL_H) $(REGS_H) hard-reg-set.h flags.h \
     real.h insn-config.h $(INSN_ATTR_H) $(RECOG_H) $(EXPR_H) $(BASIC_BLOCK_H) \
     $(TM_P_H)
*************** caller-save.o : caller-save.c $(CONFIG_H
*** 1483,1489 ****
     $(RECOG_H) reload.h $(EXPR_H) toplev.h $(TM_P_H)
  reorg.o : reorg.c $(CONFIG_H) $(SYSTEM_H) $(RTL_H) conditions.h hard-reg-set.h \
     $(BASIC_BLOCK_H) $(REGS_H) insn-config.h $(INSN_ATTR_H) \
!    $(RECOG_H) function.h flags.h output.h $(EXPR_H) toplev.h params.h $(TM_P_H)
  alias.o : alias.c $(CONFIG_H) $(SYSTEM_H) $(RTL_H) flags.h hard-reg-set.h \
     $(BASIC_BLOCK_H) $(REGS_H) toplev.h output.h $(EXPR_H) \
     $(GGC_H) function.h cselib.h $(TREE_H) $(TM_P_H)
--- 1484,1490 ----
     $(RECOG_H) reload.h $(EXPR_H) toplev.h $(TM_P_H)
  reorg.o : reorg.c $(CONFIG_H) $(SYSTEM_H) $(RTL_H) conditions.h hard-reg-set.h \
     $(BASIC_BLOCK_H) $(REGS_H) insn-config.h $(INSN_ATTR_H) \
!    $(RECOG_H) function.h flags.h output.h $(EXPR_H) toplev.h $(PARAMS_H) $(TM_P_H)
  alias.o : alias.c $(CONFIG_H) $(SYSTEM_H) $(RTL_H) flags.h hard-reg-set.h \
     $(BASIC_BLOCK_H) $(REGS_H) toplev.h output.h $(EXPR_H) \
     $(GGC_H) function.h cselib.h $(TREE_H) $(TM_P_H)
*************** ifcvt.o : ifcvt.c $(CONFIG_H) $(SYSTEM_H
*** 1531,1537 ****
     output.h $(TM_P_H)
  dependence.o : dependence.c $(CONFIG_H) $(SYSTEM_H) $(RTL_H) $(TREE_H) \
     $(C_COMMON_H) flags.h varray.h $(EXPR_H)
! params.o : params.c $(CONFIG_H) $(SYSTEM_H) params.h toplev.h
  
  $(out_object_file): $(out_file) $(CONFIG_H) $(TREE_H) $(GGC_H) \
     $(RTL_H) $(REGS_H) hard-reg-set.h real.h insn-config.h conditions.h \
--- 1532,1538 ----
     output.h $(TM_P_H)
  dependence.o : dependence.c $(CONFIG_H) $(SYSTEM_H) $(RTL_H) $(TREE_H) \
     $(C_COMMON_H) flags.h varray.h $(EXPR_H)
! params.o : params.c $(CONFIG_H) $(SYSTEM_H) $(PARAMS_H) toplev.h
  
  $(out_object_file): $(out_file) $(CONFIG_H) $(TREE_H) $(GGC_H) \
     $(RTL_H) $(REGS_H) hard-reg-set.h real.h insn-config.h conditions.h \
Index: toplev.c
===================================================================
RCS file: /cvs/gcc/egcs/gcc/toplev.c,v
retrieving revision 1.472
diff -c -3 -p -w -B -b -r1.472 toplev.c
*** toplev.c	2001/06/21 16:50:56	1.472
--- toplev.c	2001/06/26 05:03:57
*************** display_help ()
*** 3881,3887 ****
  
    printf (_("  -O[number]              Set optimisation level to [number]\n"));
    printf (_("  -Os                     Optimise for space rather than speed\n"));
!   for (i = sizeof (compiler_params); i--;)
      {
        const char *description = compiler_params[i].help;
        const int length = 21-strlen(compiler_params[i].option);
--- 3958,3964 ----
  
    printf (_("  -O[number]              Set optimisation level to [number]\n"));
    printf (_("  -Os                     Optimise for space rather than speed\n"));
!   for (i = LAST_PARAM; i--;)
      {
        const char *description = compiler_params[i].help;
        const int length = 21-strlen(compiler_params[i].option);

-- 
"I saw a sign:  "Rest Area 25 Miles".  That's pretty big.  Some
people must be really tired.
"-Steven Wright
Follow-Ups:
- Re: Fix thinko in params
  - From: Joseph S. Myers
- Re: Fix thinko in params
  - From: Kelley Cook
Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]