This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Convert rs6000 to new initial_val functions.
> Date: Thu, 21 Jun 2001 16:47:45 -0400
> From: DJ Delorie <dj@redhat.com>
> CC: gcc-patches@gcc.gnu.org, dje@watson.ibm.com
>
>
> > You didn't say how you'd tested this patch.
>
> For that and all the other port patches, I built a cc1 both with and
> without the patch and visually inspected the resulting assembler (-O3)
> for the attached test case, substituting the appropriate register for X.
That is _not_ an acceptable way of testing a patch before submission.
It's good, but it's not enough. You have to do at least a full
testsuite run, and preferably a bootstrap too. Please see
<http://gcc.gnu.org/cvswrite.html>.
I happen to know that there are a bunch of cases in the testsuite
especially for testing this functionality, and a number of them were
added due to bug reports on powerpc. So, please, always do a full
testsuite run.
--
- Geoffrey Keating <geoffk@geoffk.org>