This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Localization fixes
> confirm the platform on which you
> bootstrapped without regressions?
That's i386.
> (Given a mainline patch that addresses
> the issues you mention, I can probably review and
> apply it - but a 3.0 patch will need to wait for the
> criteria for 3.0.1 to be determined.)
Ok, I will.
> + if (code == RECORD_TYPE)
> + warning ("`struct %s' declared inside parameter list",
> + IDENTIFIER_POINTER (TREE_PURPOSE (elt)));
> + else if (code == UNION_TYPE)
>
> Can you add a comment to the code explaining why the
> struct/union/enum cases need separating?
A good reason, and one deserving no comment, is coherency,
since the cases are already separated almost everywhere.
> - { 'O', 'o', 0, NULL, N_("the `O' modifier"), STD_EXT },
> + { 'O', 'o', 0, NULL, N_("the `O' strftime modifier"), STD_EXT },
>
> Why this change? The message in which the string appears is of the form
> "ISO C does not support the `O' modifier with the `%C' strftime format",
You're obviously right -- this part is bogus.
> > diff -r -U3 old/c-parse.y ./c-parse.y
> > --- old/c-parse.y Sun Jun 17 21:51:11 2001
> > +++ ./c-parse.y Thu Jun 21 11:05:17 2001
>
> You don't mention this in your ChangeLog entry, and the source file is
> c-parse.in, not c-parse.y. This part of the change is only applicable to
> 3.0, not mainline.
This part is not very interesting too (it's just "ISO C99" being spelled as
"ISO C 99"). I will fix it for the mainline patch.
Paolo