Re: [C++] Fix 3130, 3131

[Jason Merrill <jason_merrill at redhat dot com>]

>>>>> "Nathan" == Nathan Sidwell <nathan@codesourcery.com> writes:

> that make sense?

Yes, thanks.  Eep.

>> I wish we had had more implementation experience before freezing the
>> ABI...

> you, me and Mark! This virtual primary base thing has an unbelievable
> number of unobvious side effects.

Indeed.  Had we known, I think we would have passed on the idea.

>> !       if (b == rtti_binfo
>> !         || (b && binfo_for_vbase (BINFO_TYPE (b),
>> !                                   BINFO_TYPE (rtti_binfo))))
>> !       primary = last;
> Unless I'm mistaken, this is the only assignment to PRIMARY, and LAST
> must be non-null here, so the next if can be subsumed.

True.  If binfo was primary in the old type, it must be primary (to
something) in the new type.

Jason