Re: G++ defining _GNU_SOURCE

[Geoff Keating <geoffk at geoffk dot org>]

> From: Franz Sirl <Franz.Sirl-kernel@lauterbach.com>
> Date: Mon, 11 Jun 2001 20:44:03 +0200
> Cc: gcc-patches@gcc.gnu.org
> 
> On Monday 11 June 2001 20:34, Geoff Keating wrote:
> > Franz Sirl <Franz.Sirl-kernel@lauterbach.com> writes:
> > > --------------Boundary-00=_792SG12CVE3KYHPIXWAV
> > > Content-Type: text/plain;
> > >   charset="iso-8859-1"
> > > Content-Transfer-Encoding: 8bit
> > >
> > > On Monday 11 June 2001 19:06, Richard Henderson wrote:
> > > > On Mon, Jun 11, 2001 at 12:19:24PM +0200, Franz Sirl wrote:
> > > > > On the patch itself, how can "-D_GNU_SOURCE %(cpp_cpu)" be correct?
> > > > > Shouldn't that be %(cpp)?
> > > >
> > > > I think you're right.
> > >
> > > At least powerpc-linux-gnu now bootstraps again for me with the appended
> > > patch.
> > >
> > > OK to commit to mainline and 3.0 branch?
> >
> > Shouldn't this use the *_DEFAULT_SPEC mechanism like CPP_OS_DEFAULT_SPEC?
> 
> I don't think it's worth the trouble, AFAI understand it, the whole 
> _GNU_SOURCE usage for C++ is a temporary thing until libstdc++-v3 is fixed 
> for gcc-3.1. Therefor I headed for the minimum solution.

Could you add a comment saying this should be temporary?

With that, the patch is OK.

-- 
- Geoffrey Keating <geoffk@geoffk.org>