This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: fix argument promotion
- To: John David Anglin <dave at hiauly1 dot hia dot nrc dot ca>
- Subject: Re: PATCH: fix argument promotion
- From: "Joseph S. Myers" <jsm28 at cam dot ac dot uk>
- Date: Mon, 4 Jun 2001 17:36:09 +0100 (BST)
- cc: <gcc-patches at gcc dot gnu dot org>
On Mon, 4 Jun 2001, John David Anglin wrote:
> Rodney Brown found that the testsuite failures noted in fortran PR 2782
> were related to the passing of boolean arguments on the PA. I looked
> into this and found that only INTEGER_TYPE and ENUMERAL_TYPE were being
> promoted in prototypes in C and C++. The new C99 BOOLEAN_TYPE, and also
> CHAR_TYPE under C++ were not being promoted. This patch changes the
> test to use INTEGRAL_TYPE_P instead of explicitly checking all the
> different types that need promotion. This fixes all the fortran
> testsuite failures on the PA.
>
> Bootstrapped and checked with no regressions under hppa1.1-hp-hpux10.20
> <http://gcc.gnu.org/ml/gcc-testresults/2001-06/msg00089.html> and
> i686 linux.
>
> OK for both?
The C changes are OK, but can you please add a testcase for this to the C
testsuite if one isn't there already, rather than relying on Fortran to
show the problem up? Someone else will need to review the C++ changes.
--
Joseph S. Myers
jsm28@cam.ac.uk