This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: 3.0 PATCH: Fix multilibbed libstdc++ v3 testsuite
- To: Rainer Orth <ro at TechFak dot Uni-Bielefeld dot DE>
- Subject: Re: 3.0 PATCH: Fix multilibbed libstdc++ v3 testsuite
- From: Benjamin Kosnik <bkoz at redhat dot com>
- Date: Wed, 30 May 2001 12:39:57 -0700 (PDT)
- cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org, geoffk at cygnus dot com
> * If I run e.g.
>
> make RUNTESTFLAGS='--target_board "unix{-mabi=64}"' check
>
> on IRIX 6.2, make check is still run in mips-sgi-irix6.2/libstdc++-v3,
> but with -mabi=64 to create N64 binaries. Still the linker is pointed to
> the mips-sgi-irix6.2/libstdc++-v3/src/.libs directory, which only
> contains libstdc++.so for the default (i.e. N32 in this case) multilib.
>
> I haven't attacked this yet, since I don't know for sure how make check
> for multilibs is really supposed to work.
Join the club. In general, libstdc++-v3 is trying to copy g++, which
seems like the sensible thing to do.
I don't think g++ does this correctly though, it just tests the first
multilibbed directory, as far as I can tell.
Geoff might have more insight on this stuff, which is why I cc'd him.
Thoughts?
> * Instead I've done the following: simply run make RUNTESTFLAGS=... check
> in the appropriate multilib directory,
> i.e. mips-sgi-irix6.2/mabi=64/libstdc++-v3. This allowed me to
> sucessfully compile the tests, but they failed to run since
> libgcc_s_mabi=64.so couldn't be found since LD_LIBRARY_PATH pointed to
> ${blddir}/../../gcc, missing one ../ (i.e. $MULTIBUILDTOP). I fixed this
> as follows, inspired by gcc/testsuite/lib/g++.exp (e.g. g++_link_flags).
> With this patch, I'm finally able to sucessfully run the testsuite in
> multilib subdirectories.
..this seems like the most reliable way to accomplish what you're trying
to do.
> Wed May 30 18:33:24 2001 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE>
>
> * testsuite/lib/libstdc++-v3-dg.exp (libstdc++-v3-init): Use
> get_multilibs to find gcc.
I'll check this in. Thanks!
-benjamin