This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Recent change to libf2c/libI77/Makefile.in


Loren James Rittle <rittle@latour.rsch.comm.mot.com> writes:

> [Andreas, the author of the Makefile.in fragment I am commenting upon,
>  asked me to publicly post this since he has no authority to OK the
>  patch.  This change recently went in:]

I asked not only because I don't have the authority but also because
*all* patches should go over the gcc-patches list.

>   stamp-h: config.h.in config.status
> !       CONFIG_FILES= CONFIG_HEADERS=config.h $(SHELL) config.status
> !       echo timestamp > ${srcdir}/stamp-h
>   
> This Makefile code appears wrong (and/or against current convention)
> to me.  In particular, given those exact rules and actions, there is
> absolutely no way to build from a read-only $(srcdir) anymore.  Before
> your patch, it used to be that one could build on a platform which had
> read-write access to $(srcdir) and then later builds on platforms with
> read-only access to $(srcdir) would function properly.

Upps.

> Also, it appears against current convention since it creates a new
> file in $(srcdir) which is not in the archive [or listed in a
> .cvsignore file].
> 
> Can this stamp file safely live in $(objdir)?  I think the answer is
> yes.  All stamp files that rely on newly created files in $(objdir)
> would appear to have to reside in $(objdir).
> 
> Here is the obvious patch I will install (which mirrors correct usage
> seen in libf2c/libU77/Makefile.in) after hearing from you:

It looks fine to me,

Thanks,
Andreas

> 2001-05-21  Loren J. Rittle  <ljrittle@acm.org>
> 
> 	* libI77/Makefile.in (stamp-h): Create in $(objdir) instead
> 	of $(srcdir).
> 
> Index: libf2c/libI77/Makefile.in
> ===================================================================
> RCS file: /cvs/gcc/gcc/libf2c/libI77/Makefile.in,v
> retrieving revision 1.6.20.3
> diff -c -r1.6.20.3 Makefile.in
> *** Makefile.in	2001/05/18 07:47:47	1.6.20.3
> - --- Makefile.in	2001/05/21 23:38:51
> ***************
> *** 91,97 ****
>   config.h: stamp-h; @true
>   stamp-h: config.h.in config.status
>   	CONFIG_FILES= CONFIG_HEADERS=config.h $(SHELL) config.status
> ! 	echo timestamp > ${srcdir}/stamp-h
>   
>   VersionI.o: Version.c
>   	$(CC) -c $(ALL_CFLAGS) -o $@ $(srcdir)/Version.c
> - --- 91,97 ----
>   config.h: stamp-h; @true
>   stamp-h: config.h.in config.status
>   	CONFIG_FILES= CONFIG_HEADERS=config.h $(SHELL) config.status
> ! 	echo timestamp > stamp-h
>   
>   VersionI.o: Version.c
>   	$(CC) -c $(ALL_CFLAGS) -o $@ $(srcdir)/Version.c
> 
> Regards,
> Loren
> 

-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]