This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA] Integrated hashtables for compiler + cpplib


>>>>> "Zack" == Zack Weinberg <zackw@Stanford.EDU> writes:

    Zack> and on a casual sweep I don't think any of them _need_ the
    Zack> return-0- if-not-found behavior.  Some of them look flat out
    Zack> wrong to me.

I agree.

For example, the assemble_name one is probably bogus.  It is supposed
to be an invariant that TREE_SYMBOL_REFERENCED is set for things that
are output.  So, if there's no `id' for this thing, that indicates
that either:

  - We are trying to mark the wrong thing.  Some amount of hokey
    back-end mucking with identifiers has confused us.

  - We should create one, and mark that, in case anyone else
    talks about in the future.
 
I don't know which is right -- but I think the current behavior is
probably wrong.

The only thing we want to be careful is that we don't somehow create a
bazillion extra identifiers for `_foo' because that's how this target
spells `foo' or something like that.

--
Mark Mitchell                   mark@codesourcery.com
CodeSourcery, LLC               http://www.codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]