This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: libI77: Automatically regenerate config.h.in


Alexandre Oliva <aoliva@redhat.com> writes:

> On May 16, 2001, Andreas Jaeger <aj@suse.de> wrote:
> 
> > Could some configure experts look over this, please?
> 
> > Ok to commit?
> 
> > +${srcdir}/config.h.in: stamp-h.in
> 
> You're missing the `; @true' here.
>
> > +config.h: stamp-h; @true
> > +stamp-h: config.h.in config.status
> > +	$(SHELL) config.status
> 
> You'd better define CONFIG_FILES= CONFIG_HEADERS=config.h so that
> config.status doesn't needlessly (and perhaps incorrectly) rebuilds
> Makefile.  Please consider the patch with these changes pre-approved
> for mainline and branch.
> 
> 
> I still think things might have been simpler if we just kept not using
> config.h at all.  However, if there are lots of macros AC_DEFINEd in
> configure.in, having them all in DEFS might overflow command-line
> lengths on old OSs, which are exactly those that would generally need
> the DEFS in the first place.  So moving on to config.h is a step in
> the right direction, and now that you've already done almost all of
> the work, I no longer see a reason to go back.
> 
> 
> It would be nice to have contrib/gcc_update updated to touch
> stamp-h.in and config.h.in.

I'll prepare tomorrow a patch with the missing pieces.

Thanks for your comments,
Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]