This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix bootstrap failure (both branches) with libI77/endfile for glibc 2.2.2 systems
- To: gcc-patches at gcc dot gnu dot org
- Subject: Re: Fix bootstrap failure (both branches) with libI77/endfile for glibc 2.2.2 systems
- From: Loren James Rittle <rittle at latour dot rsch dot comm dot mot dot com>
- Date: Wed, 16 May 2001 11:21:33 -0500 (CDT)
- Cc: aj at suse dot de
- Organization: Networks and Infrastructure Lab (IL02/2240), Motorola Labs
In article <u8r8xpbxzn.fsf@gromit.moeb> Andreas Jaeger writes:
> Since this patch:
> 2001-05-15 Loren J. Rittle <ljrittle@acm.org>
> * libI77/endfile.c (t_runc): Add cast to help case where
> ftruncate() prototype is somehow missing even though autoconf
> test found it properly.
I am sorry about that. I have read your analysis and all the current
follow-ups. I agree that the patch now installed beyond mine is an
improvement. I was afraid something like this might happen:
LJR> There is a problem with the second patch, this is the first
LJR> unguarded use of off_t. What if some unistd.h doesn't define it?
Although I was sceptical at the time Mark made the call, I guess
adding the cast is better than any system-specific addition. Now, at
least you are likely to get a build failure instead of a latent bug
which is not findable until run-time. Since during follow-up we
learned that a prototype for ftruncate was not in scope on glibc 2.2.2
systems either...
Regards,
Loren