This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Fix for regression due to SYMBOL_REF patch to dwarf2out.c


I don't think that special casing CONST_DOUBLE like this is the right fix;
the problem is that Nick's patch is wrong for all constant pool refs where
the target isn't another SYMBOL_REF.

A simple fix would be to narrow Nick's patch to only cases where
get_pool_constant returns another SYMBOL_REF.  Another possible fix would
be to remove Nick's patch entirely and pull out the pool constant earlier,
say in add_location_or_const_value_attribute, so that we could use
DW_AT_const_value for these constants.

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]