This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Detect _Bool in bootstrap compiler


Fergus Henderson writes:

> This check is checking whether there's a built-in _Bool.
> The check will (and should) fail on systems which define _Bool in <stdbool.h>.

True, those systems won't test for HAVE__BOOL since system.h first checks
for HAVE_STDBOOL_H and looks at HAVE__BOOL only if <stdbool.h> doesn't
exist.

> But on such systems it would be reasonable to say that "_Bool is
> supported" and that "the `_Bool' type works".

Agreed.  That patch originated from the long double test, mainly by
cut-and-paste ;-)

> So I suggest s/works/is built-in/
> and s/supported/is built-in/.
> 
> > +AC_DEFUN(gcc_AC_C__BOOL,
> > +[AC_CACHE_CHECK(for _Bool, gcc_cv_c__bool,
> 
> Likewise here "checking for _Bool" is a little misleading.
> I suggest s/for _Bool/for built-in _Bool/.
> 
> (Or perhaps "built in" or "builtin" rather than "built-in";
> I'm not sure of the correct spelling.)

Webster has `built-in', so I'd go for that.

Ok with these changes?

	Rainer

-----------------------------------------------------------------------------
Rainer Orth, Faculty of Technology, Bielefeld University

Email: ro@TechFak.Uni-Bielefeld.DE


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]