This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: x86_64 merger part 19 - trivial i386.c bits


On Mon, Mar 19, 2001 at 06:29:48PM +0100, Jan Hubicka wrote:
> -   if (!TARGET_USE_SAHF && !optimize_size)
> +   if ((!TARGET_USE_SAHF && !optimize_size) || TARGET_64BIT)

Seems like it would be cleaner to force TARGET_USE_SAHF false.

> *************** ix86_attr_length_immediate_default (insn
> + 		case MODE_DI:
>   		  len+=4;

Surely a DImode immediate has length 8?  If you're playing
games with sign/zero extension, I'd set attr mode to SI,
since that's the actual mode of the constant.

Otherwise ok.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]