Re: Projects for beginners: break up expand_expr

[Momchil Velikov <velco at fadata dot bg>]

>>>>> "Stan" == Stan Shebs <shebs@apple.com> writes:

Stan> Momchil Velikov wrote:
>> 
>> Thus patched, the compiler bootstraps without regressions on
>> i686-pc-gnu-linux and bootstraps on powerpc-apple-netbsdelf1.5 (don't
>> have dejagnu there yet). Btw, without the patch compiling expr.c uses
>> more than 100M, with the patch - under 15M.  Makes much difference on
>> my 32M machine.

Stan> Is there a noticeable effect on compile time?  In theory, the extra
Stan> function call overhead shouldn't be observable, but we have a slow
Stan> compiler partly because of many people assuming that their changes
Stan> don't have any effect, yet the aggregate effect is pretty bad.

Patched compiler:
time ./xgcc -B./ -B/usr/local/i686-pc-linux-gnu/bin/ -c  -DIN_GCC    -g -O2 -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wtraditional -pedantic -Wno-long-long  -DHAVE_CONFIG_H    -I. -I. -I/home/velco/src/local-gcc/gcc -I/home/velco/src/local-gcc/gcc/. -I/home/velco/src/local-gcc/gcc/config -I/home/velco/src/local-gcc/gcc/../include /home/velco/src/local-gcc/gcc/combine.c -o combine.o

real	0m30.510s
user	0m30.110s
sys	0m0.180s

Unpatched compiler:
./xgcc -B./ -B/usr/local/i686-pc-linux-gnu/bin/ -c  -DIN_GCC    -g -O2 -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wtraditional -pedantic -Wno-long-long  -DHAVE_CONFIG_H    -I. -I. -I/home/velco/src/local-gcc/gcc -I/home/velco/src/local-gcc/gcc/. -I/home/velco/src/local-gcc/gcc/config -I/home/velco/src/local-gcc/gcc/../include /home/velco/src/local-gcc/gcc/combine.c -o combine.o

real	0m30.621s
user	0m30.030s
sys	0m0.270s

Both are stage3 compilers on PII-266.

Looks almost the same.

Regards,
-velco