This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: PATCH: 64-bit uncleanliness fix


On Sat, 17 Mar 2001, Richard Henderson wrote:

> On Sat, Mar 17, 2001 at 02:01:38PM -0500, Brad Lucier wrote:
> > Before sending this, I grepped all 'define ASM_OUTPUT_INTERNAL_LABEL'
> > in config/*; none of them perform a cast.  And the argument is
> > really a long unsigned int on all architectures.  So I don't see how
> > your suggestion is correct.
> 
> Only ASM_OUTPUT_INTERNAL_LABEL knows that printf format
> specifier it used.

The documentation in tm.texi - which presumably provides the specification
of the requirements for this interface (as is to be provided by backends)
- says

	The usual definition of this macro is as follows:

	@example
	fprintf (@var{stream}, "L%s%d:\n", @var{prefix}, @var{num})
	@end example

By implication, the interface for users of the macro is that they must
pass an int.  If this is changed, the documentation needs updating.

-- 
Joseph S. Myers
jsm28@cam.ac.uk


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]