This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFA] cpplib/C/C++: Unify character constant interpretation
- To: John Marshall <john_marshall at palm dot com>
- Subject: Re: [RFA] cpplib/C/C++: Unify character constant interpretation
- From: Neil Booth <neil at daikokuya dot demon dot co dot uk>
- Date: Tue, 6 Mar 2001 07:23:40 +0000
- Cc: Stan Shebs <shebs at apple dot com>, gcc-patches at gcc dot gnu dot org,zackw at Stanford dot EDU
- References: <200103060304.TAA12330@wsp000702wss.ops.palm.com>
John Marshall wrote:-
> > /* In C, a character constant has type 'int'; in C++, 'char'. */
> > - if (chars_seen <= 1 && c_language == clk_cplusplus)
> > + if (c_language == clk_cplusplus)
> > TREE_TYPE (value) = char_type_node;
> > else
> > TREE_TYPE (value) = integer_type_node;
>
> This is incorrect. Whatever their values might happen to be, C++ char
> literals containing more than one char have type int (section 2.13.2).
Thanks - I don't have a C++ standard; I guess I should buy one:-)
I'll revert this; the main reason I changed this was that the "chars_seen"
variable no longer exists (in this routine, at least) and I didn't think
anyone used it, but clearly they do.
Neil.