This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: xm-*.h cleanup, continued


 > From: "Zack Weinberg" <zackw@Stanford.EDU>
 > 
 > On Sat, Mar 03, 2001 at 12:03:12AM -0500, Kaveh R. Ghazi wrote:
 > >  >       * crtstuff.c: Include tconfig.h, not auto-host.h and tm.h.
 > > 
 > > Gross as it sounds, I think crtstuff really needed auto-host.h to get
 > > the definition of HAVE_GAS_HIDDEN.  Apparently this was setup to work
 > > correctly even though its host vs target.
 > 
 > Aaargh.  What does HAVE_GAS_HIDDEN do and why didn't something break?

It guards `asm (".hidden\t__dso_handle");' in crtstuff.c.  I guess
you'd only care if you're playing with DSOs.


 > And would you mind fixing it?  I have too many hacks in my tree
 > right now.
 > zw

Fixing it probably only requires doing the following.  My linux box's
gas doesn't support .hidden and I don't know of any testcases anyway.
So I can't test it or claim it works.  But its the same action taken
before your patch, so...  OK to install as an "obvious" fix to your
last patch?

		--Kaveh


diff -rup orig/egcs-CVS20010305/gcc/crtstuff.c egcs-CVS20010305/gcc/crtstuff.c
--- orig/egcs-CVS20010305/gcc/crtstuff.c	Fri Mar  2 22:32:00 2001
+++ egcs-CVS20010305/gcc/crtstuff.c	Mon Mar  5 13:18:01 2001
@@ -55,6 +55,9 @@ Boston, MA 02111-1307, USA.  */
    compiled for the target, and hence definitions concerning only the host
    do not apply.  */
 
+/* We include auto-host.h here to get HAVE_GAS_HIDDEN.  This is
+   supposedly valid even though this is a "target" file.  */
+#include "auto-host.h"
 #include "tconfig.h"
 #include "tsystem.h"
 #include "frame.h"


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]