This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: Enum related fixes for gcc build with native cc on vax ultrix
- To: 'John David Anglin' <dave at hiauly1 dot hia dot nrc dot ca>, rth at redhat dot com
- Subject: RE: Enum related fixes for gcc build with native cc on vax ultrix
- From: Bruce Korb <bkorb at allegronetworks dot com>
- Date: Fri, 2 Mar 2001 16:17:28 -0800
- Cc: gcc-patches at gcc dot gnu dot org, bkorb at gnu dot org
> > Eh? Perhaps this gets fixed with Zack's boolean cleanup patch.
>
> Yes, I believe that this is fixed in the main but not the
> branch. Zack is not going to patch the branch. ...
> Zack's commit didn't kill this and he doesn't want to touch it, so I
> have copied Bruce Korb.
Did you have to? :-(
> 2) For the main and the branch,
>
> 2001-02-19 John David Anglin <dave@hiauly1.hia.nrc.ca>
>
> * fixinc/fixlib.h (bool_t): Add identifier `boolean' in typedef.
> * fixinc/server.c (read_pipe_timeout): Use enum boolean instead of
> t_bool in declaration because pcc can't combine volatile with
typedef
> types.
"t_bool", not "bool_t". POSIX claims title to all names ending in "_t".
> --- fixinc/fixlib.h.orig Wed Dec 13 15:07:46 2000
> +++ fixinc/fixlib.h Wed Feb 21 17:54:05 2001
> @@ -88,7 +88,7 @@
>
> #define IGNORE_ARG(a) ((void)(a))
>
> -typedef enum
> +typedef enum boolean
> {
> BOOL_FALSE, BOOL_TRUE
> } t_bool;
> --- fixinc/server.c.orig Wed Feb 21 17:54:28 2001
> +++ fixinc/server.c Wed Feb 21 17:55:11 2001
> @@ -57,7 +57,7 @@
> # define volatile
> #endif
>
> -STATIC volatile t_bool read_pipe_timeout;
> +STATIC volatile enum boolean read_pipe_timeout;
> STATIC pid_t server_master_pid = NOPROCESS;
That is completely disgusting.
I recommend something other than `boolean', however, because
it is too likely to become conflicted with something. I still
dream of the day when you can use TRUE and FALSE without
worrying about funny things getting in the way...
Otherwise, please feel free to apply it under the "obviously
disgusting" rule.