This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: xm-*.h cleanup, continued


This part:
 > -xm_file="gansidecl.h ${xm_file} defaults.h"
 > +xm_file="${xm_file} tm.h"

and related bits are wrong, IMO.

The ordering around xm_file (etc) is important, i.e. gansidecl must be
first so that we get consistent macro defs (e.g. "const").  You don't
want stuff in xm_file to conflict with repeats later on because you
happened to define const away in ansidecl.h.  I suspect your patch
will also break any xm_file that uses PARAMS, ATTRIBUTE_*, or other
macros from ansidecl.h.

You also have to ensure defaults.h comes last, so you cannot put tm.h
before the xm_file either.

I would suggest instead taking gansidecl.h/defaults.h out of tm_file
and including tm.h between xm_file and defaults.h.  Then change the
three files that include tm.h directly to include tconfig.h.

		--Kaveh
--
Kaveh R. Ghazi			Engagement Manager / Project Services
ghazi@caip.rutgers.edu		Qwest Internet Solutions


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]