This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: sibcall fixup
On 18-Feb-2001, Richard Henderson <rth@redhat.com> wrote:
> On Sun, Feb 18, 2001 at 07:03:15PM -0500, Richard Kenner wrote:
> > I also got rid of the gotos in the code in question
> > (yes, I understand that some might consider the replacement worse ..).
>
> Me for one. I absolutely hate gigantic if conditions.
>
> This one, for instance, barely fits on the screen. Please do not
> create such things. If you absolutely positively must get rid of
> the gotos, please extract this condition into its own function and
> split it up into multiple tests and returns.
I agree. This one is IMHO a particularly pernicious example of a gigantic
`if' condition, because of all the side effects in the sub-expressions.
--
Fergus Henderson <fjh@cs.mu.oz.au> | "I have always known that the pursuit
| of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh> | -- the last words of T. S. Garp.