This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: One more optimize_mode_switching() problem
On Feb 9, 2001, Richard Henderson <rth@redhat.com> wrote:
> On Fri, Feb 09, 2001 at 04:24:43PM -0200, Alexandre Oliva wrote:
>> + if (GET_CODE (eg->src->end) == JUMP_INSN)
>> + emit_insn_before (mode_set, eg->src->end);
>> + else
>> + eg->src->end = emit_insn_after (mode_set, eg->src->end);
> I havn't looked closely at the rest of the patch yet, but the most
> common abnormal edge to the exit block is a sibling call. You should
> be testing != INSN not == JUMP_INSN.
Neither calls nor sibcalls should be a problem. call insns already
require a switch into normal mode, so we should never need adjustments
after them. At least on the SH.
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist *Please* write to mailing lists, not to me