This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Fix preferred_stack_boundary initialization


wallner@ims.uni-hannover.de (Jens Wallner) writes:

> > Looking through the stack alignments issues I mentioned on the gcc
> > list, I noticed the following bug - and it might be that this fixes
> > the problem Jens had (Jens, can you check this?  The patch is against
> > current gcc from CVS).
> > 
> > Is this ok to commit?  Or did I misunderstood the documentation?
> > 
> > I've bootstrapped and run make check on i686-linux.
> >
> > Andreas
> >
> > 2001-02-03  Andreas Jaeger  <aj@suse.de>
> >
> >	* function.c (prepare_function_start): Correctly set
> >	preferred_stack_boundary.
> 
> I think function.c is NOT the correct place to fix the reported
> misaligned stack. 

I found a bug in GCC and fix it this way.  It might be that this is
not the whole story but a bug should be fixed in any case.

[...]
> The startup code in glibc's start.S is also correctly aligned.
> Geert Bosch explained that very well. Please note, from startup 
> in start.S is NOT called user's main function!! There is some
> more startup stuff implemented:

I know, it calls __libc_start_main which is a C function (check
sysdeps/generic/libc-start.c) and that function seems to misalign the
stack which implies that this is a GCC bug.

Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]