This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Remove some warnings
>>>>> Bernd Schmidt writes:
> On 12 Jan 2001, Andreas Jaeger wrote:
>> * config/i386/i386.c (ix86_expand_fp_compare): Remove unused label
>> do_sahf.
>> (ix86_init_builtins): Make i unsigned to remove warnings.
>> (ix86_expand_builtin): Likewise.
>>
>> * gencodes.c (output_predicate_decls): Make i unsigned to avoid
>> warning about comparison between signed and unsigned.
> Isn't it possible for sizeof to return a signed type on some hosts? Maybe
> this is better fixed with casts in the for statements?
It is possible - but ISO C99 demands size_t as result. As far as I
understand the warnings rule (the code should be fine with signed and
unsigned sizeof), we're concerned about warnings in stage 3 of GCC -
and therefore unsigned should be ok. The question is if we care about
those non ISO C99 compliant systems for these warnings? I don't know
what's the general rule is for GCC in this case.
>> * haifa-sched.c (restore_line_notes): Remove argument block B
>> since it's unused.
>> * sched-ebb.c (schedule_ebb): Change caller.
>> * sched-rgn.c (schedule_region): Likewise.
>> * sched-int.h: Change prototype.
> This part is ok.
Thanks, I'll commit that part now,
Andreas
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
http://www.suse.de/~aj