This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Loop iv debugging patch
- To: Michael Hayes <mhayes at redhat dot com>
- Subject: Re: Loop iv debugging patch
- From: Andreas Jaeger <aj at suse dot de>
- Date: 12 Jan 2001 12:10:22 +0100
- Cc: gcc-patches at gcc dot gnu dot org
- References: <14941.2331.949024.263257@taniwha.paradise.net.nz>
>>>>> Michael Hayes writes:
> This patch adds some debugging routines to the loop optimiser
> to dump an iv class or all the iv classes for a loop.
> 2001-01-11 Michael Hayes <mhayes@redhat.com>
> * loop.h (total_biv_increment): Constify iv_class pointer.
> (struct induction): Replace `mem_mode' with `mem' rtx.
> * unroll.c (total_biv_increment): Constify iv_class pointer.
> * loop.c (loop_giv_reduce_benefit): Derive mem mode from mem rtx.
> (find_mem_givs, combine_givs_p): Likewise.
> (debug_ivs, debug_iv_class, loop_ivs_dump, loop_iv_class_dump): New.
[...]
> Index: loop.h
> ===================================================================
> *************** rtx loop_insn_hoist PARAMS((const struct
> *** 416,418 ****
> --- 416,419 ----
> /* Forward declarations for non-static functions declared in doloop.c. */
> int doloop_optimize PARAMS ((const struct loop *));
> + rtx doloop_condition_get PARAMS ((rtx));
Bootstrapping gcc I get:
/cvs/gcc/gcc/doloop.c:60: warning: static declaration for `doloop_condition_get'
follows non-static
Michael, why did you add a declaration to loop.h? I can't find a
ChangeLog entry for it and it looks wrong (check the two static
declarations in doloop.c).
Btw. you also didn't change the Copyright for loop.h.
Is the appended patch ok to commit? It passed a bootstrap on
i686-linux.
Andreas
2001-01-12 Andreas Jaeger <aj@suse.de>
* loop.h: Remove wrong declaration of doloop_condition_get.
Index: loop.h
===================================================================
RCS file: /cvs/gcc/egcs/gcc/loop.h,v
retrieving revision 1.49
diff -u -r1.49 loop.h
--- loop.h 2001/01/12 04:09:43 1.49
+++ loop.h 2001/01/12 09:43:52
@@ -1,5 +1,6 @@
/* Loop optimization definitions for GNU C-Compiler
- Copyright (C) 1991, 1995, 1998, 1999, 2000 Free Software Foundation, Inc.
+ Copyright (C) 1991, 1995, 1998, 1999, 2000, 2001
+ Free Software Foundation, Inc.
This file is part of GNU CC.
@@ -416,4 +417,3 @@
/* Forward declarations for non-static functions declared in doloop.c. */
int doloop_optimize PARAMS ((const struct loop *));
-rtx doloop_condition_get PARAMS ((rtx));
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
http://www.suse.de/~aj