This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Simple ix86 fp compares cleanup/fix
- To: Jan Hubicka <jh at suse dot cz>
- Subject: Re: Simple ix86 fp compares cleanup/fix
- From: Richard Henderson <rth at redhat dot com>
- Date: Tue, 9 Jan 2001 11:19:02 -0800
- Cc: patches at x86-64 dot org, gcc-patches at gcc dot gnu dot org
- References: <20010109194707.B11282@atrey.karlin.mff.cuni.cz>
On Tue, Jan 09, 2001 at 07:47:07PM +0100, Jan Hubicka wrote:
> + /* Split comparison code CODE into comparisons we can do using branch
> + instructions. BYPASS_CODE is comparison code for branch that will
> + branch around FIRST_CODE and SECOND_CODE. If some of branches
> + is not required, set value to UNKNOWN.
Consider NIL as a more intuitive choice for "not needed" than UNKNOWN.
> ! if (bypass_code == UNKNOWN && second_code == UNKNOWN
> ! && (TARGET_CMOVE || (TARGET_USE_SAHF || optimize_size)))
Extra parentheses?
Looks good otherwise.
r~